search

mono / xwt

A cross-platform UI toolkit for creating desktop applications with .NET and Mono
MIT License
1.37k stars 241 forks source link

[Bug 992658] Update FileSelector accessibility #981

Closed GouriKumari closed 5 years ago

GouriKumari commented 5 years ago

Fixes: https://devdiv.visualstudio.com/DevDiv/_queries/edit/992658

GouriKumari commented 5 years ago
Screen Shot 2019-10-09 at 6 37 50 PM

@sevoku : https://devdiv.visualstudio.com/DevDiv/_queries/edit/992658 requires a fix in .NET Empty project options. On debugging it looks like the issue is with accessibility of file selector. Could you verify this. Also, can you let me know how to verify these changes locally.

rodrmoya commented 5 years ago

@GouriKumari just do the change on main/external/xwt, and then build as usual, monodevelop will use the Xwt build from that dir.

sevoku commented 5 years ago

@GouriKumari as Rodrigo explained it's a submodule under main/external/xwt, so you can just pull your changes there. But keep in mind that running make will reset it to the upstream commit.

WRT changes: I'm not sure what you are trying to achieve. Theoretically it should be enough to set a Accessibility.Label for those entries in MD code, that's it.

sevoku commented 5 years ago

Oh ,also, due to a limitation in current Xwt API this component will be announced as group with the title and label. One needs to enter the group to interact with the entry and button)

GouriKumari commented 5 years ago

@sevoku : I think the issue is here in VSFMac code https://github.com/mono/monodevelop/blob/master/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects.OptionPanels/AssemblyRunConfigurationEditor.cs#L98 . But the FileSelector code is in xwt, https://github.com/mono/xwt/blob/master/Xwt/Xwt/FileSelector.cs#L165. That is the reason why I tried to change it in xwt.

GouriKumari commented 5 years ago

@sevoku : I think I can close this PR. It looks like accessibility is working fine without this fix in 8.3.2. https://www.dropbox.com/s/ya4dvn8ro1vihoa/FileSelector%20Save.mov?dl=0 -> This is the screencast when tested from md-addins. With 8.3.2 instead of "Enter File Path" , VO says "Path, you are in an edit text area" . VO is reading the label set here, https://github.com/mono/xwt/blob/5b93b4bdf6e5d7329a7ea59c7c041ee388289396/Xwt/Xwt/FileSelector.cs#L175.