search

mono0926 / LicensePlist

A license list generator of all your dependencies for iOS applications
https://www.slideshare.net/mono0926/licenseplist-a-license-list-generator-of-all-your-dependencies-for-ios-applications
MIT License
2.42k stars 145 forks source link

Fix no name bug with trailing slash in URL #202

Closed acevif closed 2 years ago

acevif commented 2 years ago
acevif commented 2 years ago

I have not succeeded in reproducing the Lint violations in my local environment.

$ mint run SwiftLint swiftlint lint --strict .
🌱 Finding latest version of SwiftLint
🌱 Running swiftlint 0.49.1...
Linting Swift files at paths .
Linting 'ResultOperation.swift' (2/61)
Linting 'main.swift' (1/61)
Linting 'AutoColorMode.swift' (3/61)
Linting 'APIKit.extension.swift' (4/61)
Linting 'URL.extension.swift' (5/61)
Linting 'Extensions.swift' (6/61)
Linting 'String.extension.swift' (7/61)
Linting 'Consts.swift' (8/61)
Linting 'CocoaPodsLicense.swift' (9/61)
Linting 'GitHubRequest.swift' (10/61)
Linting 'SearchRequests.swift' (11/61)
Linting 'RepoRequests.swift' (12/61)
Linting 'Options.swift' (13/61)
Linting 'Manual.swift' (14/61)
Linting 'Environment.swift' (15/61)
Linting 'Library.swift' (16/61)
Linting 'LicensePlistHolder.swift' (17/61)
Linting 'HasName.swift' (18/61)
Linting 'GitHubLibraryConfigFile.swift' (19/61)
Linting 'ManualLicense.swift' (20/61)
Linting 'Exclude.swift' (21/61)
Linting 'PlistInfo.swift' (22/61)
Linting 'CocoaPods.swift' (23/61)
Linting 'LicenseHTMLHolder.swift' (24/61)
Linting 'VersionInfo.swift' (25/61)
Linting 'GitHubLicense.swift' (26/61)
Linting 'LicenseMarkdownHolder.swift' (27/61)
Linting 'GitHub.swift' (28/61)
Linting 'SwiftPackage.swift' (29/61)
Linting 'XcodeProjectFileReader.swift' (30/61)
Linting 'SwiftPackageFileReader.swift' (31/61)
Linting 'Config.swift' (32/61)
Linting 'FileReader.swift' (33/61)
Linting 'LicenseType.swift' (34/61)
Linting 'License.swift' (35/61)
Linting 'Shell.swift' (37/61)
Linting 'Logger.swift' (36/61)
Linting 'LicensePlist.swift' (38/61)
Linting 'URL.extensionTests.swift' (39/61)
Linting 'RepoRequestsTests.swift' (40/61)
Linting 'ConfigTests.swift' (41/61)
Linting 'SearchRequestsTests.swift' (42/61)
Linting 'GitHubLibraryConfigFileTests.swift' (43/61)
Linting 'PlistInfoTests.swift' (44/61)
Linting 'CocoaPodsTests.swift' (45/61)
Linting 'SwiftPackageManagerTests.swift' (46/61)
Linting 'GitHubTests.swift' (47/61)
Linting 'LicensePlistHolderTests.swift' (48/61)
Linting 'XcodeWorkspaceFileReader.swift' (49/61)
Linting 'GitHubLibraryConfigFileTypeTests.swift' (50/61)
Linting 'VersionInfoTests.swift' (51/61)
Linting 'GitHubLicense.collectorTests.swift' (52/61)
Linting 'LicenseTests.swift' (53/61)
Linting 'ExcludeTests.swift' (54/61)
Linting 'XcodeWorkspaceFileReaderTests.swift' (55/61)
Linting 'AutoColorModeTests.swift' (56/61)
Linting 'SwiftPackageFileReaderTests.swift' (57/61)
Linting 'XcodeProjectFileReaderTests.swift' (58/61)
Linting 'EnvironmentTests.swift' (59/61)
Linting 'TestUtil.swift' (60/61)
Linting 'ResultOperationTests.swift' (61/61)
Done linting! Found 0 violations, 0 serious in 61 files.
acevif commented 2 years ago

I am guessing that I have hit this bug: https://github.com/realm/SwiftLint/issues/4031#issuecomment-1258808240

acevif commented 2 years ago

@mono0926 I think I could have fixed the problem now.

I appreciate your patience.

Is it better to rebase it to organize it?

mono0926 commented 2 years ago

@acevif

Thanks 🙏

Is it better to rebase it to organize it?

Whichever you prefer is fine 👌

acevif commented 2 years ago

@mono0926 I've rebased it.

It is ready for review now. Thanks!

mono0926 commented 2 years ago

@acevif

Thanks, released 🚀 https://github.com/mono0926/LicensePlist/releases/tag/3.23.4