search

monocasual / giada

Your Hardcore Loop Machine.
https://www.giadamusic.com
GNU General Public License v3.0
1.72k stars 98 forks source link

FreeBSD support #200

Closed monocasual closed 4 years ago

monocasual commented 6 years ago

Original pull request: https://github.com/monocasual/giada/pull/218

yurivict commented 4 years ago

Could you please merge the latest FreeBSD patch to the master?

monocasual commented 4 years ago

@yurivict this is planned for 0.16.1, coming very soon. Please be patient :wink:

yurivict commented 4 years ago

Thank you.

monocasual commented 4 years ago

@yurivict FreeBSD branch squashed and merged into master. Looks good?

yurivict commented 4 years ago

The build breaks:

error: use of undeclared identifier 'kernelMidi'; did you mean 'm::kernelMidi'?
        if (kernelMidi::hasAPI(RtMidi::UNIX_JACK))
            ^~~~~~~~~~
            m::kernelMidi
./src/core/kernelMidi.h:39:11: note: 'm::kernelMidi' declared here
namespace kernelMidi
          ^
src/gui/elems/config/tabAudio.cpp:98:6: error: use of undeclared identifier 'kernelAudio'; did you mean 'm::kernelAudio'?
        if (kernelAudio::hasAPI(RtAudio::UNIX_JACK))
            ^~~~~~~~~~~
            m::kernelAudio
monocasual commented 4 years ago

Should be fixed now (commit d8b7b01779540f1775a6525b84af10d4852c516e).

yurivict commented 4 years ago

Still:

src/gui/elems/config/tabAudio.cpp:486:3: error: use of undeclared identifier 'conf'; did you mean 'm::conf'?
                conf::soundSystem = G_SYS_API_JACK;
                ^~~~
                m::conf
./src/core/conf.h:38:11: note: 'm::conf' declared here
namespace conf
          ^
src/gui/elems/config/tabAudio.cpp:488:3: error: use of undeclared identifier 'conf'; did you mean 'm::conf'?
                conf::soundSystem = G_SYS_API_PULSE;
                ^~~~
                m::conf
./src/core/conf.h:38:11: note: 'm::conf' declared here
namespace conf
          ^
monocasual commented 4 years ago

Hopefully fixed in 5051bf92fd5f16c416114561c0ddbe0f2c5f99e9, and 26ebbce7f1af889b28f43e234d72297b7b091500

yurivict commented 4 years ago

It works now.

Thank you for fixing the issues!