monocasual / giada

Your Hardcore Loop Machine.
https://www.giadamusic.com
GNU General Public License v3.0
1.7k stars 99 forks source link

some lv2 GUI's fail to initialize #608

Open CarloCattano opened 2 years ago

CarloCattano commented 2 years ago

Environment

Opening some lv2 plugins on a track FX leads to the UI not opening and the regular generic UI doesnt show up. I will do more tests to tell exactly which plugins fail to do so.

Here is an example with zam plugins

[pluginManager::makePlugin] plugin instance with pid=LV2-ZamComp-3daa6d14-3daa6d14 created
[Plugin] plugin initialized and ready. MIDI input params: 8
[gdPluginWindowGUI] Opening editor
WARNING: this host does not send sample-rate information for LV2 UIs, using 44100 as fallback (this could be wrong)
X_CreatePixmap: BadValue (integer parameter out of range for operation) 0x0
X_CopyArea: BadDrawable (invalid Pixmap or Window parameter) 0x560c911
X_FreePixmap: BadPixmap (invalid Pixmap parameter) 0x560c911

Steps to reproduce the behavior:

  1. Open giada
  2. Create a sample channel
  3. Add an FX lv2 like zamComp
  4. No UI is displayed

Expected behavior GUI appears or a fallback generic UI should be created from the params

Additional context I know lv2 its pretty recent, just wanted to help see if we can get things going

gvnnz commented 2 years ago

Thanks @CarloCattano for the report & investigation. I recommend to test plug-ins also in the JUCE Plug-in Host app and see if they work there.

CarloCattano commented 2 years ago

They do pretty much. Tested in Carla and BespokeSynth, the latter with lv2 juce 7 implemented

gvnnz commented 2 years ago

Thanks. I added some fixes to the plug-in's UI initialization here: 15f0ab4c87f6ac59955f96872c941ea1885b03ae .

CarloCattano commented 2 years ago

Hm. Now they open but dont display anything. Is a step forwards tho

[gdPluginWindowGUI] Opening editor
X_CreatePixmap: BadValue (integer parameter out of range for operation) 0x0
X_CopyArea: BadDrawable (invalid Pixmap or Window parameter) 0x5a25249
X_FreePixmap: BadPixmap (invalid Pixmap parameter) 0x5a25249

image

gvnnz commented 1 year ago

Might be related: https://github.com/juce-framework/JUCE/issues/1123