search

monochromegane / gannoy

Approximate nearest neighbor search server and dynamic index written in Golang.
MIT License
42 stars 8 forks source link

Support to validate kernel version for centos #1

Closed takaishi closed 7 years ago

takaishi commented 7 years ago

Occur following error when execute gannoy-db on CentOS. uname -sr return Linux 4.12.2-1.el7.elrepo.x86_64 on CentOS, this is not a valid semver identifier.

panic: failed to validate pre-release: 1.el7.elrepo.x86_64 is not a valid semver identifier

goroutine 7 [running]:
github.com/coreos/go-semver/semver.Must(0x0, 0xa26360, 0xc4200f67e0, 0xa26360)
        /root/go/src/github.com/coreos/go-semver/semver/semver.go:65 +0x54
github.com/coreos/go-semver/semver.New(0xc420011ec6, 0x1a, 0x8669d0)
        /root/go/src/github.com/coreos/go-semver/semver/semver.go:49 +0x57
github.com/monochromegane/gannoy.newLocker(0x7d4d40, 0x1)
        /root/go/src/github.com/monochromegane/gannoy/lock.go:27 +0x1cc
github.com/monochromegane/gannoy.newFile(0xc4200b1620, 0x1a, 0x1, 0x800, 0x3, 0xc4200b1560)
        /root/go/src/github.com/monochromegane/gannoy/file.go:42 +0xde
github.com/monochromegane/gannoy.newNodes(0xc4200b1620, 0x1a, 0x1, 0x800, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /root/go/src/github.com/monochromegane/gannoy/node.go:12 +0xa1
github.com/monochromegane/gannoy.NewGannoyIndex(0xc4200b1560, 0x1a, 0xa2c360, 0xa76e08, 0xa2a4a0, 0xa76e08, 0x0, 0x0, 0x0, 0x0, ...)
        /root/go/src/github.com/monochromegane/gannoy/gannoy.go:44 +0x16e
main.gannoyIndexInitializer(0xc42005e5a0, 0xc42005e600, 0xc42005e660)
        /root/go/src/github.com/monochromegane/gannoy/cmd/gannoy-db/main.go:305 +0x159
created by main.main
        /root/go/src/github.com/monochromegane/gannoy/cmd/gannoy-db/main.go:135 +0x7ba

So, how about to normalize kernel version before validate?

monochromegane commented 7 years ago

LGTM! Thanks a lot 👍