monochromegane / the_platinum_searcher

A code search tool similar to ack and the_silver_searcher(ag). It supports multi platforms and multi encodings.
MIT License
2.81k stars 141 forks source link

Comply with semantic import versioning #211

Closed Loyalsoldier closed 3 years ago

Loyalsoldier commented 3 years ago

For Go v1.15.6 in Homebrew https://github.com/Homebrew/homebrew-core/pull/66355

carlocab commented 3 years ago

Thanks, @Loyalsoldier.

If this PR is merged, it would also be helpful for Homebrew if you cut a new release that includes this PR. At the moment CI failures associated with formulae that still depend on godep is holding back the go version bump.

shigemk2 commented 3 years ago

How about wercker.yml? the_platinum_searcher uses wercker as CI tool. We have to delete godep from wercker.yml https://github.com/monochromegane/the_platinum_searcher/blob/master/wercker.yml#L5-L18.

carlocab commented 3 years ago

If you make that change, please squash your commits so I only need one commit hash for the Homebrew patch.

shigemk2 commented 3 years ago

Well, I do not have to fix wercker.yml right away because wercker uploads artifacts.