Closed DavidSatimeWallin closed 8 years ago
ghost
commented
8 years ago @dashaus I think the last changes you did broke it, please fix it, Iris framework uses your library and I hope that this will not change.
Edit 2: @dvwallin the iris' version is working now, @dashaus the problem was the nil slice, you're late to answer so I forced to make a fork of your code and edit it.
emilgpa
commented
8 years ago @dvwallin can you pass me the code that you are using? @kataras In the tests, the slices aren't initialize and are passed successfully.
ghost
commented
8 years ago Create a real example and you will see, this was the fix for our version of your package
emilgpa
commented
8 years ago I fixed a bug related with unmarshalText. I don't know if the bug is related with your problem @dvwallin. Try it again, please!
@kataras I use formam strongly in my project, and I use a lot slices. No problem I've found...
ghost
commented
8 years ago We had a problem with nil slices, I fixed because ,obviously, you will not xD anyway thanks for your package, is very good and simple, continue this!
emilgpa
commented
8 years ago if d.curr.IsNil() {
_newSlice := reflect.MakeSlice(d.curr.Type(), len(d.values), len(d.values))
reflect.Copy(_newSlice, d.curr)
d.curr.Set(_newSlice)
}It is your fix? Because it is redundant. The expandSlice function does this!
emilgpa
commented
8 years ago And the d.values is only used when the field is slice/array without proving an index! Be careful...
emilgpa
commented
8 years ago And I have never had to do make([]string, 0), it is not necessary. Please, create a example without to use your framework and you can see that the error is no produced
ghost
commented
8 years ago And the d.values is only used when the field is slice/array without proving an index! Be careful..
Yes, because of this I'm using this , if it's 0 then no problem (golang no-setted int types are zero) , make an empty slice, and after expand it as you say, this is not something to worry about it.
It is your fix? Because it is redundant. The expandSlice function does this!
expandSlice doesn't expand the nil slices.
And I have never had to do make([]string, 0), it is not necessary. Please, create a example without to use your framework and you can see that the error is no produced
I did with pure fasthttp and html/template. Did you try to do an example with fasthttp or you use only net/http for your tests? Please do it and after answer me correctly. Thanks!
emilgpa
commented
8 years ago expandSlice doesn't expand the nil slices.
expandSlice expands nil slices. Your fix is not a fix. Is an unnecessary redundancy. It not should to do any effect positive neither negative in your framework. Your fix is a placebo: https://play.golang.org/p/p47CqZY7A9
I did with pure fasthttp and html/template. Did you try to do an example with fasthttp or you use only net/http for your tests? Please do it and after answer me correctly. Thanks!
If fasthttp encode the form's values as do net/http, then there should not be any problem. If fasthttp encode the form's values in another way, formam is not the package to use, formam only allow url.Values for decode in a struct or slice.
ghost
commented
8 years ago Well written answer, you've right.
Just updated (removed repo and did go get -u on this repo) and im getting a panic on reflection