search

monogon-dev / NetMeta

NetMeta is a scalable network observability toolkit optimized for performance.
https://netmeta.demo.monogon.dev/
Apache License 2.0
133 stars 8 forks source link

Use IPv4-mapped IPv6 instead of custom format #108

Closed fionera closed 1 year ago

fionera commented 1 year ago

Currently we are storing IPv4 Addresses as ::1.2.3.4, this should be corrected and changed to ::ffff:1.2.3.4. Currently only the Portmirror is writing its SamplerAddress in this format.

leoluk commented 1 year ago

Portmirror should probably use the "old" format in the meantime, or things get really weird in a mixed env?

fionera commented 1 year ago

Its only the SamplerAddress which is written that way, so nothing that could create issues. But yes it should be streamlined.

There is a change in review to replace fix this: https://review.monogon.dev/c/NetMeta/+/974

fionera commented 1 year ago

Maybe we should not edit existing Data and just create a VIEW that changes the resulting data? Or do you have any better idea on how to solve this? My current solution is to copy all data into a different table, while also migrating it and then copying it back to keep existing changes by the user

fionera commented 1 year ago

Implemented with https://github.com/monogon-dev/NetMeta/commit/a35efbde4a07b3e039d6810e4931a589a2fc81d7. For migration see UPGRADE.md