"Monokai Pro Light" is categorized as a dark theme in VSCode Color Theme select menu

monokai-pro / vscode

Issue tracking for Monokai Pro for Visual Studio Code

https://monokai.pro

327 stars 7 forks source link

"Monokai Pro Light" is categorized as a dark theme in VSCode Color Theme select menu #421

Open shawnrivers opened 2 weeks ago

shawnrivers commented 2 weeks ago

When opening VSCode color theme picker by opening the command palette (Shift + CMD/CTRL + P) and selecting "Preferences: Color Theme", the "Monokai Pro Light" and "Monokai Pro Light (Filter Sun)" themes are shown under the "dark themes" selection along with other dark themes.

LawrenceLiu023 commented 2 weeks ago

I noticed that some the foreground colours of some buttons are white, making it hard to distinguish them from the background. This phenomenon may be related to this issue. Because the light theme is categorized as a dark theme, the default foreground colour will be light.

lkrms commented 1 week ago

I imagine this is the reason that configuring "Monokai Pro Light" as my default light theme (workbench.preferredLightColorTheme) doesn't work; the "Toggle between Light/Dark Themes" command does nothing until I revert to my previous light theme.

Hopefully this isn't too difficult to fix, because the theme is an improvement in every other respect :)