search

monokrome / jaded-brunch

Jade for brunch, supporting both dynamic and static loading jade.
MIT License
23 stars 10 forks source link

Fixed crash bug in latest Brunch #18

Closed BernieSumption closed 8 years ago

BernieSumption commented 8 years ago

The current version of brunch and current version of jaded-brunch crash on compiling a .static.jade file. The cause of this is not passing the second parameter into callback on successful execution of the compile function.

BernieSumption commented 8 years ago

On second thoughts, this is a Brunch bug not a jaded-brunch bug. Passing null as a second parameter to the callback used to be supported as a way of emitting no source for a compiled asset, now that's broken. I'll submit a PR to Brunch instead.

monokrome commented 8 years ago

@BernieSumption If they come back to you saying that it's not brunch's problem then can you let me know? They don't seem to be very fair in their reasoning for closing PRs, so I expect this issue to become a jaded-brunch issue even if it's really an undocumented API change in brunch.

I've stopped using brunch, but I want to make sure that this project is still in working order. Thanks a ton for submitting this PR.

BernieSumption commented 8 years ago

Not to worry, my PR has been merged already. Might take a small while to get into an npm release.