search

monokrome / jaded-brunch

Jade for brunch, supporting both dynamic and static loading jade.
MIT License
23 stars 10 forks source link

Brunch getDependencies wrong arguments #20

Closed nakedcity closed 8 years ago

nakedcity commented 8 years ago

Brunch calls like:

return promisifyPlugin(2, compiler.getDependencies).call(compiler, data, path);

but progeny calls like: => data, path, compiler

Please modify to solve it: (JS version, CS version included in the patch)

var progenyDeps = progeny({
      rootPath:  ....
    });
    this.getDependencies = function(compiler, data, path){
      progenyDeps(data, path, compiler)
    }
nakedcity commented 8 years ago

Fix in CS attached here It's also tested , can you please merge?

fix-issue-https-github.com-monokrome-jaded-brunch-is.diff.zip

monokrome commented 8 years ago

@samio80 Are you able to send this as a pull request?

monokrome commented 8 years ago

@samio80 Thanks so much for reporting this! Does https://github.com/monokrome/jaded-brunch/pull/21 look like what you're expecting? If so, I'll test that it's working.

monokrome commented 8 years ago

@samio80 Closing this now, and we can work on it in #21 since you've confirmed that #21 is the ideal state. Feel free to reopen this issue if you feel like it should be open! Thanks again :)