search

monokrome / jaded-brunch

Jade for brunch, supporting both dynamic and static loading jade.
MIT License
23 stars 10 forks source link

Refactor causing: "Loading of jaded-brunch failed due to jadePath is not defined" #27

Closed dcostaras closed 7 years ago

dcostaras commented 7 years ago

Hi,

Apologies if I get things wrong.

My package.json looks like:

  'brunch': '>= 2.x'
  'jaded-brunch': '>= 2.x'

...and it's presenting the following Loading of jaded-brunch failed due to jadePath is not defined.

So I had a look at the repo and it seems there is a refactor happening on master. Specifically with jadePath being out of scope to it's use here.

Changing jaded-brunch to explicitly use 2.3.0 or 2.2.4 fixed the issue.

NPM is mystery to me so I'm not sure why I'm getting master which is 2.2.5 in package.json when there is no 2.2.5 tag in git. As well as why I don't get 2.3.0 when I have >= 2.x in my package.json.

Also I had to clear node_modules locally to recreate the issue which originally happened in during deployment as CI started from a fresh node_modules everytime.

Ciao, Donavan

monokrome commented 7 years ago

@pseudonamed Thanks for the report... I'm fixing it now. So sorry :(

monokrome commented 7 years ago

@pseudonamed This should be fixed in 2.2.6. My apologies again for this. Please feel free to reopen if it isn't fixed for you!

The fix is here: https://github.com/monokrome/jaded-brunch/commit/d7febd0fabc02c56c3c81dbb1643b01b2a750d43

dcostaras commented 7 years ago

Thanks for the quick fix, looks good. :)

monokrome commented 7 years ago

@pseudonamed Thanks for following up and submitting your report!