monokrome / jaded-brunch

Jade for brunch, supporting both dynamic and static loading jade.
MIT License
23 stars 10 forks source link

Semantic Versioning and `1.7.8-hotfix-2` #7

Closed Lalem001 closed 10 years ago

Lalem001 commented 10 years ago

Semantic versioning resolves 1.7.8-hotfix-2 as a lesser version than 1.7.8.

According to server.org, a pre-release is:

denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version

Thus -hotfix-2 is telling semver that it is a pre-release for 1.7.8.

Would you mind retagging as 1.7.9?

monokrome commented 10 years ago

Thanks, @Lalem001. I'll update it now. The annoying thing here is that you're conventionally expected to version it based on the version of brunch that you are using. :/

Lalem001 commented 10 years ago

Just looked over the Brunch FAQ, and it says the following about version numbers:

Brunch x.y.z releases are compatible with plugins (in this case eco-brunch) x.(<= y).*. This means that:

  • brunch 1.1.0 with plugin 1.0.0.
  • brunch 1.1.0 with plugin 1.1.9.
  • brunch 1.9.14 with plugin 1.5.6.

Basically Brunch only really cares about the MAJOR, and MINOR, version numbers. The PATCH number is ignored. Thus your plugin could go to 1.7.9 and it will still be considered compatible.

monokrome commented 10 years ago

@Lalem001 I guess that brunch is just trying to enforce semantic versioning by convention as a mapping to plugins then. Thanks for the details here, I'll keep that in mind.