search

monome / crow

Crow speaks and listens and remembers bits of text. A scriptable USB-CV-II machine
GNU General Public License v3.0
166 stars 34 forks source link

Broken norns scripts with 3.0 #418

Closed trentgill closed 3 years ago

trentgill commented 3 years ago

We deprecated / moved some norns functions and they have broken a handful of scripts. @tehn made a list of these somewhere (i think in the norns crow-namespace PR) & they should all be one-liner fixes.

alternatively, i'm not totally opposed to keeping some old aliases to these functions. ideally we would do both, while ensuring the documentation is clear about which to use. that way norns scripts won't break on older-versions of norns (and scripts that dont have PRs merged / aren't public) won't be broken.

dndrks commented 3 years ago

list: https://github.com/monome/norns/pull/1362#issuecomment-866941444 -- perhaps worth noting that cyrene is not on this list, though it was reported as having trouble: https://llllllll.co/t/crow-v3/46425/18

cheat codes doesn't actually have any breakage, from what i can tell, so safe to skip it :)

i agree that aliases would be good for private scripts to continue working, with docs updated to reflect current practice.

trentgill commented 3 years ago

closing as we did a bunch of PRs to fix breaking changes, and merged a couple backward-compatibility changes into main