search

monome / crow

Crow speaks and listens and remembers bits of text. A scriptable USB-CV-II machine
GNU General Public License v3.0
166 stars 34 forks source link

Fixes docker run command for bash shell in dev docs #427

Closed jonpliske closed 3 years ago

jonpliske commented 3 years ago

This change updates the documentation to reflect that the ENTRYPOINT needs to be explicitly set to bash, otherwise the container execution will interpret "bash" as an argument.

I believe this could also be resolved via changes to the Dockerfile: changing ENTRYPOINT to CMD will allow the behavior you describe in the doc. I'm not sure of the exact use case (i.e. where else this container is run...), but if you're trying to set the default but overridable execution flow then CMD might be a better fit.

tehn commented 3 years ago

seems good to me? i don't run docker though--- @trentgill ?

trentgill commented 3 years ago

Similarly i’ve never used the docker image. Unsure of the github actions use it, or if that’s separate?

CC @simonvanderveldt @csboling who may have some insight / be able to confirm.

simonvanderveldt commented 3 years ago

I don't know if any other commands than what's currently defined in the entrypoint (which is make) are to be run? Personally I can't think of any so I'd just remove all arguments in the readme so it just runs the container and will use the entrypoint as defined in the image.