monome / crow

Crow speaks and listens and remembers bits of text. A scriptable USB-CV-II machine
GNU General Public License v3.0
166 stars 34 forks source link

i2c reliability #458

Closed trentgill closed 1 year ago

trentgill commented 2 years ago

Unrelated to the pullup-centric PR, this is a (WIP) set of improvements to the i2c driver & ii layer to better handle errors.

especially when a message fails to send on an otherwise ok bus (due to another device taking control) we now retry sending that message. there is no timeout or limit, and this does mean the "ii lines are low" message is no longer sent if pullups are already enabled.

more to come

trentgill commented 1 year ago

Merging this on the belief that i tested it well back in 2021! I remember testing it well, and also the high-reliability mode being default should improve 90% of issues people have with their i2c bus failing. Will be especially useful with a crow+JF combination.

The whole firmware needs some good i2c testing, and i think this should help with most general use cases.