Closed trentgill closed 1 year ago
@dndrks please do further testing using this branch as it includes all of the updates for the proposed 4.0
direct download: https://github.com/monome/crow/suites/11236996367/artifacts/575310576
this fixes all the issues from the timeline
branch (:times resets correctly, 'reset' works correctly on score), and changes to the new :play
and :stop
behaviour as discussed. also uses timeline.real
name change.
currently running the long-time test to see if the random stopping is fixed... EDIT: had this running for a good 15mins and the it's still swinging away:
timeline.loop{sequins{0.6,0.4}, function() output[4](pulse(0.005,2)) end}
EDIT AGAIN: this has been running for a good 5-6 hours and still banging away nicely. i think we're good to go!
once we get this all tested, i think this is the release candidate for 4.0 and will be time to move onto documentation and tooling updates (eg: norns firmware update)
rad rad rad!! @trentgill , so super exciting!!!!
@dndrks thanks for this. the function swapping thing is something i found & noted in the timeline PR as well. i wrote up some more notes about it there, but basically it's a feature of how lua works and i don't know if there's a way around it. hotswap seems like the solution for now.
re: hotswap
library. yes it will be included. i had pushed it to 4.1, but honestly it's a tiny library and seemed to work well. i thought it was contributing to the timelines-stopping-running-after-some-time issue, but turns out it was not causally related. my only concern is that it's one more layer to introduce people to. i think we can manage that with documentation though so i'll get it all bundled together and do some more testing this afternoon.
@dndrks @tehn i'll get everything merged this afternoon as there's lots of tricky git navigation that needs to happen. omw to test drive some cars though, so it'll be your tomorrow-workday before i get it all done. thank you both for the work! really happy to see this all coming together, and excited to writeup some new docs to communicate all these new really cool features!
shweee!!
@trentgill , oh jeez sorry, i think i muddied the water on this:
the function swapping thing is something i found & noted in the timeline PR as well
the initial problem was totally from that PR :)
my real q's covered under using the API less successfully, where i had assumed that i could use hotswap
to not only swap variables but whole timeline
modes, following the success of the other tests outlined in that section.
rad rad rad, can't wait to dig in to docs with ya!! also ooo new transportation!! vrooooom
Just a temporary PR to have a public zip file for testing.