Closed simonvanderveldt closed 5 years ago
This looks good to me, and I don't mind the extra packages now that we're using an automated setup with pip. I can't really comment on the implementation, but it's at least terse and reads cleanly to the uninitiated (read: myself).
Perhaps you could add a section to the readme which describes the necessary steps to make a new release? I know it's going to be automated at some point, but would be good to document the current situation.
Perhaps you could add a section to the readme which describes the necessary steps to make a new release? I know it's going to be automated at some point, but would be good to document the current situation.
Good point! I'll add that tomorrow.
@simonvanderveldt lmk what I can do to test this out and then let's check it in!
@trentgill I don't expect it to behave differently on different OSes but if you could give it a spin on Mac OS and Windows that would be nice (although @csboling might do that as well)
Tested all my systems and it seems to be working well! Merging now.
I just learned like seven new things about pip and git from trying to understand how this works, awesome. Very tidy solution!
This uses https://pypi.org/project/setuptools-scm/ + https://pypi.org/project/setuptools-scm-git-archive/ which is a bit "magic", but from my testing this is the only way to get the version automatically with the following criteria:
git tag
dev
should be shownSome output examples:
And when making a release archive (which is what GitHub does):
And when installing from this archive
@csboling what do you think?
Fixes #29