search

monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 34 forks source link

filter .DS_Store or others from maiden menus #110

Closed okyeron closed 5 years ago

okyeron commented 6 years ago

I started using Transmit today (from my Mac) to sftp to norns and now I'm seeing the invisible files ".DSStore" and "..DS_Store" in my maiden menu listings. (also using SAMBA, so I'm not sure which one is generating those DS_Store files)

I suppose these invisible files just need to be filtered out of the list?

screen shot 2018-06-14 at 3 11 50 pm

phonk commented 6 years ago

seconded. Not really an important functionality but it ruins a bit Maiden's elegance.

ngwese commented 6 years ago

this shouldn’t be too bad to add. will look into it

nf commented 6 years ago

It could make sense to just filter out all dotfiles. I volunteer to do this, if that's what we want to do.

okyeron commented 5 years ago

Wanted to ping this topic again - Noticed today that the .git directory shows up in subdirectories

Also - what to do about readme.md files? Probably leave them visible?

simonvanderveldt commented 5 years ago

Is there no way to exclude what you're sending to norns in the tool you're using?

tehn commented 5 years ago

we just need to filter normal dot files

I believe @ngwese is on it

On Sun, Feb 24, 2019, 2:01 PM Simon van der Veldt notifications@github.com wrote:

Is there no way to exclude what you're sending to norns in the tool you're using?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/monome/maiden/issues/110#issuecomment-466811272, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPEcPzLglGr-a1aIjy_08rCtBZUlZg-ks5vQu-LgaJpZM4UolxN .

simonvanderveldt commented 5 years ago

No chance someone wants to store something in a .dot dir and wants to edit that?

ngwese commented 5 years ago

This ticket should be addressed by this change once it is merged. https://github.com/monome/maiden/commit/747e828f74727ab3a187217be59519c4452fd988

UPDATE: re editing files in dot directories. I’m not to worried about that - folks placing stuff in dot directories or naming files with a dot probably know what they are doing and can edit those files via a different mechanism than maiden. That said I should probably add validation to prevent people from renaming files starting with a ‘.’

ngwese commented 5 years ago

Fixed as of https://github.com/monome/maiden/commit/747e828f74727ab3a187217be59519c4452fd988