monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 34 forks source link

new layout: support multiple tabs and movable panes #138

Closed ngwese closed 4 years ago

ngwese commented 5 years ago

allow more flexible ui layouts:

ngwese commented 5 years ago

...it's looking like this might be a rough road. apparently in order to work with reactjs one needs to arrange for React, ReactDOM, and jquery packages to be loaded in the global namespace. loading packages into the global namespace looks like it falls outside of what one can configure with the boilerplate build configuration we are getting from react-scripts.

https://github.com/andrewcapodieci/golden-layout-react-redux/issues/7

i'm experimenting with "ejecting" the boilerplate build and which bakes it into maiden directly which allows for more configuration. the ejecting process appears to be bringing other issues with it.

tehn commented 5 years ago

this is a naive question, but is it possible to do what we want without react?

ngwese commented 5 years ago

react is the framework which provides the structure for the app - specifically the ui/dom generation and state propagation. removing react essentially amounts to rewriting most of maiden.

there may be other options and i haven't given up on golden layout yet.

at the end of the day multiple editor tabs seems like the most critical feature from a layout perspective.

ngwese commented 5 years ago

some experimentation with https://www.npmjs.com/package/flexlayout-react in a test project proved promising and looks to be a much more react friendly path forward.

image

simonvanderveldt commented 5 years ago

Really liking the (dark themed) look of this!

ngwese commented 4 years ago

unlikely going to more forward with this in the current implementation