Could scrollback amount be configurable?

monome / maiden

web based editor and repl for norns

GNU General Public License v3.0

47 stars 34 forks source link

Could scrollback amount be configurable? #142

Open okyeron opened 5 years ago

okyeron commented 5 years ago

Would it be possible to have a configuration for the number of lines of REPL scrollback?

ngwese commented 5 years ago

It is currently hard coded to 300 lines but it is done in a way that could be made configurable (the scroll back limit is part of the application state along with other properties). Adding a control on the editor settings page would be the most straightforward.

One potential thing that sound be tested is the performance as the number of lines grows - there are some know problems with the way REPL view renders.

okyeron commented 5 years ago

Aha... understood. Ran into a situation today where I was printing out a huge table and thought this might be a useful feature.

Not a big deal either way.