monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 33 forks source link

Polish up some the project management bits #170

Closed ngwese closed 4 years ago

ngwese commented 4 years ago

Adds several modal dialogs to provide more positive indication that work is being done on the device. The UI is not the most elegant (and could use some refinement) but it is complete enough to be usable.

Resolves #137

/cc @ryanlaws

ryanlaws commented 4 years ago

This looks super cool. How do I initialize the catalog(s)?

ngwese commented 4 years ago

@ryanlaws if you run make release, copy the tarball over to norns, remove the existing maiden dir, unpack the tarball, run the project-setup.sh script in the maiden dir you should be good to go.

...then reboot or systemctl restart norns-maiden

ngwese commented 4 years ago

@ryanlaws - would certainly love to get your feedback and suggestions for pushing this functionality forward even more. The progress dialogs aren't really progress dialogs (they just show text while the operation is happening right now).

ryanlaws commented 4 years ago

I appreciate it! I will try to spend some time with this today.

ngwese commented 4 years ago

I’ll confirm later this evening. Thanks for the update!

ryanlaws commented 4 years ago

No problem - I apologize in advance if it's something stupid I did. I will try to keep an eye on this thread so I can be responsive.

ngwese commented 4 years ago

Sorry - there was one crucial detail I forgot. The "source" files to be included in the release build are pulled in via a git submodule. If you run git submodule update --init in your clone and redo the make release it should work.

ryanlaws commented 4 years ago

Ah great! I am away from my machine for a bit but will try ASAP!

ryanlaws commented 4 years ago

Ah, that was it! Great. Do you think these steps would be worth calling out in the docs somewhere? Not just the submodules but also the make release, which I thought was called out in the maiden docs but now I can't find it.

At first glance, this looks really good! It is slightly tough to read with the low-ish contrast colors but they do look really nice together. It feels like the amount of information shown here is about right.

It's great to be able to install stuff from here. This really seems like a missing link to me. The only issues I see at the moment, which are almost definitely not news to you, are:

I will play with this more tomorrow and add any additional feedback I have. Thank you!