search

monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 33 forks source link

removing 'update failed' if already up to date #201

Closed tpltnt closed 3 years ago

tpltnt commented 3 years ago

Hi there,

if I update a maiden project with is already up to date, I get a confusing error message: "update failed: already up to date". This leaves me thinking that the update process somehow went wrong (and no new version could be retrieved). This PR detect exactly this case and proceeds with a successful update message (and thus hopefully reduces confusion for the user).

Best regards, tpltnt

ngwese commented 3 years ago

oh, awesome. thanks for the pr. will check in out later today!

(I’ll readily admit the current behavior is not great)

ngwese commented 3 years ago

On reviewing this change more closely it does not appear to work - in particular it doesn't compile because is it comparing a value of Error type to a string which is not allowed in Go (to the best of my knowledge).

Was there more to this change which didn't make it into the PR?

While testing this change I noticed a bug in the make release target where it would create a tarball and exit successfully even when the go build for the maiden backend failed.

ngwese commented 3 years ago

Closing this out in favor of #202 which provides a more comprehensive fix.