improve ux when installing or updating projects

[ngwese]

addresses "update all" confusion where projects which were up to date were listed as failures in the summary modal. when projects are installed or successfully updated a modal now acknowledges success instead of immediately returning to the project listing

additionally:

• updates go-git from v4.1.2 to v5.2.0
• release.sh exits if any command errors

when a script is installed a confirmation dialog is show:

when a single script/project is updated successfully:

when a single script/project is updated but there are no changes:

when "update all" sees changes:

when "update all" does not result in any changes:

[tehn]

i can separate out the "state reset" from the "system reset" as separate menu items?

On Sun, Mar 28, 2021, 7:46 AM dan derks @.***> wrote:

@.**** requested changes on this pull request.

woahh thank you greg! the UI improvements are really legible and make the process a lot clearer 🥇

i have some concerns about the SYSTEM > RESET recommendation, please let me know if that needs more detail

In web/src/project-activity.js https://github.com/monome/maiden/pull/202#discussion_r602868690:

@@ -13,6 +13,8 @@ import { orderResultsByProjectName } from './model/project-actions';

import './project-activity.css';

import ModalProgress from './modal-progress';

+const SYSTEM_RESET_RECOMMENDATION = 'Run SYSTEM > RESET to ensure engine changes take effect';

SYSTEM > RESET overwrites a user's current audio levels (including reverb, compressor, and softcut) and favorites. could we change this text to say "restart norns to ensure engine changes take effect"?

it might be way outside of scope, but would it be possible/helpful to have a macro button in this dialogue that just executes ;restart to the SC and then matron layers? so a user can follow a one-stop action? @.*** https://github.com/tehn , or would a system "restart" action which could do the same make more sense?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monome/maiden/pull/202#pullrequestreview-622741903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4I4CX6N5A5FTD7BPKOQDTF4JJFANCNFSM4Z5VBGCA .

[tehn]

sorry, "restart" as you suggested is a better word

On Sun, Mar 28, 2021, 7:46 AM dan derks @.***> wrote:

@.**** requested changes on this pull request.

woahh thank you greg! the UI improvements are really legible and make the process a lot clearer 🥇

i have some concerns about the SYSTEM > RESET recommendation, please let me know if that needs more detail

In web/src/project-activity.js https://github.com/monome/maiden/pull/202#discussion_r602868690:

@@ -13,6 +13,8 @@ import { orderResultsByProjectName } from './model/project-actions';

import './project-activity.css';

import ModalProgress from './modal-progress';

+const SYSTEM_RESET_RECOMMENDATION = 'Run SYSTEM > RESET to ensure engine changes take effect';

SYSTEM > RESET overwrites a user's current audio levels (including reverb, compressor, and softcut) and favorites. could we change this text to say "restart norns to ensure engine changes take effect"?

it might be way outside of scope, but would it be possible/helpful to have a macro button in this dialogue that just executes ;restart to the SC and then matron layers? so a user can follow a one-stop action? @.*** https://github.com/tehn , or would a system "restart" action which could do the same make more sense?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monome/maiden/pull/202#pullrequestreview-622741903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4I4CX6N5A5FTD7BPKOQDTF4JJFANCNFSM4Z5VBGCA .

[ngwese]

cool, the RESET bit was part of what i wanted to get eyes on. happy to change the text to whatever or remove. my goal was to help prevent the common “it doesn’t work after i install” confusion.

another potential option is to offer a button in the confirmation dialog that does the restart (i think there is even an issue for something like that). sorry i’m still asleep, i see this is already a suggestion from @dndrks!

...or it might even be possible for me to scan the project dirs for .sc files to make any behavior conditional on that

[dndrks]

...or it might even be possible for me to scan the project dirs for .sc files to make any behavior conditional on that

this would rule if it isn't too much work!

[tehn]

i feel that confirmation with forced restart (no matter the update) isn't a bad thing (restart is quick, and not interruptive given people would be already doing updates vs. editing or playing)

the extra effort to scan for sc files seems like time better spent elsewhere (i value your time!)

i will implement the extra restart menu command, and add a confirm dialog to reset which seems a good safeguard

On Sun, Mar 28, 2021, 10:47 AM dan derks @.***> wrote:

...or it might even be possible for me to scan the project dirs for .sc files to make any behavior conditional on that

this would rule if it isn't too much work!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monome/maiden/pull/202#issuecomment-808906880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4I4HCOTYV7D7LUQOVUYDTF46PDANCNFSM4Z5VBGCA .

[tehn]

ok this is here now: https://github.com/monome/norns/pull/1332

i'd suggest juts changing the text to SYSTEM > RESTART which means people don't lose their faves/etc. auto/forced restart could be later.

[ngwese]

i've updated the PR to use SYSTEM > RESTART as the recommend action. i see value in looking into a button to offer that directly in the dialog but i'd like to pursue that as a different change (will open a ticket)