search

monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 34 forks source link

Play audio files in maiden #212

Closed stvnrlly closed 3 years ago

stvnrlly commented 3 years ago

This leverages react-audio-player and some very basic logic to play a file with an audio/* MIME type instead of showing the editor. This would address #83, I believe (in its original intent, not the upload/download idea).

However, it takes a moment to load the file, and during that time still displays the editor. That's a little confusing, but I know nothing about React so I'm not sure where to fix that. If somebody could give me a pointer, I'd be happy to add that to this PR.

ngwese commented 3 years ago

oh super. i’ll check it out asap!

i’m sure this will be welcome

stvnrlly commented 3 years ago

Awesome! I'll check out that tweak; this is my first React, so it'll help me learn a bit more.

ngwese commented 3 years ago

The addition I made is more to accommodate the quirks of how the buffers are handled than anything React specific.

If you really want to get a sense of what is going on the Redux DevTools are essential.