search

monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 34 forks source link

cmd-/ key binding does not work #95

Open adrianfon9 opened 6 years ago

adrianfon9 commented 6 years ago

key binding in default (ace) does not function as comment toggle in the default (ace) editor even with focus within editing window.

pq commented 6 years ago

added context from lines:

I am using safari 11.1.1 on 10.13.5

dansimco commented 6 years ago

Just confirming this is still an issue? Can't replicate it myself. I'm looking into implementing some keyboard shortcuts at the moment and thought I'd take a swing past this issue while looking at keybinds.

pq commented 6 years ago

hiya @dansimco . i haven't cycled back to this but would be pretty surprised if it weren't still in an issue. browser quirks. 😬

or wait, are you on os x? and using safari? what versions?

what kinds of refinements did you have in mind?

synthetiv commented 5 years ago

I'm on Mac OS Mojave version 10.14.6, Safari 12.1.2, and Cmd-/ works fine for me when editing Lua files. It does NOT work on SuperCollider files, in either Safari, Chrome, or Firefox, but I'm sure that's because Ace doesn't know enough about SC to know what a line comment would look like, and I know there's another issue here for that.

If this is still an issue for the OP, it might be a conflict with a browser extension.

dansimco commented 5 years ago

As a workaround to a few quirks like this, I can recommend using https://fluidapp.com/ on Mac to make yourself a "Maiden" app. For one it saves me from accidentally backing-out of the page when pressing cmd+[ . Maiden also looks really nice in it's own app.

synthetiv commented 5 years ago

Good point! Nativefier is a solid open source option for this. More fiddly to configure, but you can even set up an app to be frameless (no titlebar). I haven't been using maiden long enough to do this yet, but I'm sure I will eventually...