search

monome / meadowphysics-maxpat

tangled cascade counter with rapid tactile rule changing
3 stars 1 forks source link

varibrightness bug in mp.js under max 7 #1

Open kirbyj opened 9 years ago

kirbyj commented 9 years ago

setup: 2014 varibright 128 with max 7.0.4, serialosc 1.4, meadowphysics 1.2, teletype 1.1

issue: meadowphysics no longer displays varibright behaviour.

localised to this app, as triggers, sum, etc all display expected varibright behaviour.

no problems under max 6.1.8.

seems to be a problem with the varibright detection in mp.js: if i set line 10

var varBright = 0;

to 1, varibrightness returns; however, this then breaks compatibility with non-varibrightness devices.

presumably function variableB(x) on line 136, which is meant to set the variable brightness state, is not being called? (it's certainly not referenced elsewhere in mp.js as far as i can see.)

tehn commented 9 years ago

wondering if the new serialosc.maxpat isn't correctly passing the varbright osc message. will look into it.