search

monome / norns-image

79 stars 16 forks source link

Listen on port 80 when starting maiden and pass socket as fd #47

Closed nf closed 6 years ago

nf commented 6 years ago

See issue monome/maiden#92.

nf commented 6 years ago

This must not be merged until monome/maiden#94 is merged to master.

nf commented 6 years ago

Thanks for testing it Greg! Glad it worked. 😊

On Sat, 2 Jun 2018 at 13:53, Greg Wuller notifications@github.com wrote:

@ngwese approved this pull request.

i've verified this change on device. the required modification to maiden has been merged but a release including the change has not cut been cut.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/monome/norns-image/pull/47#pullrequestreview-125354826, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEjpUN1w7upRfvL4hyu_WN0kHV-LH2Uks5t4gwdgaJpZM4UWMVj .

ngwese commented 6 years ago

merging this as there is now a maiden release which includes the needed -fd support. https://github.com/monome/maiden/releases/tag/v0.9.1