search

monome / norns-image

81 stars 16 forks source link

Remove plymouth #71

Closed simonvanderveldt closed 5 years ago

simonvanderveldt commented 5 years ago

Turns out we can just uninstall it, no need to keep it and mask it's units.

Because we've masked the plymouth units so far (i.e. symlinked them to /dev/null) when uninstalling the plymouth package these masked units remain, which isn't very clean so I've added the unmask commands to revert that. These commands do nothing if the unit is already unmasked (as is the case in a plain raspbian install).

artfwo commented 5 years ago

haven't been following the discussions lately, is there some issue with plymouth?

ranch-verdin commented 5 years ago

There's no known reproducible bug in 2.0 due to Plymouth, however I managed to accidentally enable some part of it in my image whilst modifying norns systemd scripts and it really wreaked havoc.

If there's no reason it needs to be in there I do think wise to uninstall, since it can cause mayhem including locking up usb serial terminal...

simonvanderveldt commented 5 years ago

Would there be a reason to keep it?

artfwo commented 5 years ago

Would there be a reason to keep it?

Well, the fewer differences we have between the stock raspbian and the norns image - the easier it is to maintain (not being in disagreement with the PR).

simonvanderveldt commented 5 years ago

Well, the fewer differences we have between the stock raspbian and the norns image - the easier it is to maintain (not being in disagreement with the PR).

Yeah, that's the disadvantage of using a regular distro, we'll need to make some changes here and there to make it work for our purposes (and slim it down a bit, 2 out of the 4GB storage used by the base system is a bit too much).

The changes in this PR are rather safe in that even if raspbian would change and plymouth wouldn't be installed they would all still succeed.

[edit] I also got annoyed by the warning in the logs, trying to get rid of all the errors and warnings.