monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
633 stars 147 forks source link

grid module C code assumes 4 quads on device #1307

Closed catfact closed 4 months ago

catfact commented 3 years ago

the implementation of grid refresh in device_monome.c always assumes 4 quads of LEDs.

after a call to g.all(), all four quads are marked dirty, so 4x map messages will be sent on refresh.

this doesn't appear to cause any problems with most devices, but it seems like older/slower grid models might respond strangely. (flickering, etc.)

so we should probably teach device_monome to respect device size.

dndrks commented 4 months ago

fixed in #1358 <33