monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
633 stars 147 forks source link

[converged] reduce `nng` thread counts #1711

Open catfact opened 1 year ago

catfact commented 1 year ago

re: https://github.com/monome/norns/pull/1706#issuecomment-1746933181

i've forked the nng repo under monome and noted what appear to be the relevant vars in nng/CMakeLists.txt

set(NNG_MAX_TASKQ_THREADS 16 CACHE STRING "Upper bound on taskq threads, 0 for no limit")

set(NNG_MAX_EXPIRE_THREADS 8 CACHE STRING "Upper bound on expire threads, 0 for no limit")

my wonderings:


also mostly out of curiousity: is having excess nng threads a significant / blocking issue? seems like if idle they wouldn't have too much impact