search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
633 stars 147 forks source link

add Particle font #1745

Closed dansimco closed 11 months ago

dansimco commented 11 months ago

This pr adds in a font I've created for compact norns ui. Discussed on the study group discord here

important

I've added this font in to the list in it's alphabetically sorted position, which makes it font_face(3) this is potentially a breaking change for scripts which had used Roboto-Thin, which would now be font_face(4) and so on down the line. It might be better to add new fonts like this to the end of the list, though that would break the alpha sorting.

specimen

The font itself is open source and licensed under SIL OPEN FONT LICENSE for collaboration.

ambv commented 11 months ago

Yeah, for backward compatibility I think it shouldn't be font_face(3).

tehn commented 11 months ago

i do think we need to change this so that the index is at the end as to not break compatibility. in the end, it's just the code that sees the alphabetization.

separately, we should add a lookup table from lua so we could do font_face('particle') etc!

this font looks so good!!

dansimco commented 11 months ago

Thanks! I'm happier with the result of appending it to end of the list and later adding a name lookup. I have some other display styles I'm working on which felt like they shouldn't be earlier in the list just because they were there alphabetically. I'll adjust and push an update to this branch.

dansimco commented 11 months ago

Ok PR updated. Particle is now font_face(68) . I'll be away from home for a couple of weeks, I can make changes via github ui but wont be able to test until ~12/17