search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
633 stars 147 forks source link

tape playback unresponsive if preview is not stopped #1758

Open tapecanvas opened 9 months ago

tapecanvas commented 9 months ago

I've noticed an issue on my norns shields (all running most recent update):

In Tape, if a file is previewed and the preview is not stopped with e3 before selecting the file, there will be not output from Tape, even though the screen displays the selected file and playback display.

After this happens, I am unable to hear the preview of any other files, and any new file selected (if previewed or not) will also not play in Tape.

Upon testing this while I write this issue, I noticed that if I preview a file and leave that preview running and select another file to preview in the same directory, all preview sounds stop. Then if a file is selected to play in Tape, no sound is produced

My method around this for now has been: "After turning k3 to the right to preview, turn it back to the left to end preview before going back to preview another file. Likewise if you want to select the previewed file to play in tape, stop the preview before selecting."

link to lines thread that also mentions this problem

robbielyman commented 9 months ago

as i mentioned on lines, i'm happy to take a stab at this. it sounds like somehow whatever function turning E3 left is calling just needs to be called in more cases. i have vague memories of attempting that fix already, but i wouldn't be surprised if i missed something...

catfact commented 8 months ago

we can't reliably fix this by adding debounce timers in lua, the timing is hardware dependent and etc.

we need to just make the tape state machine more robust.