search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
630 stars 145 forks source link

Encoder acceleration not working, enc() passing -1/1 only #1779

Closed dstroud closed 4 months ago

dstroud commented 4 months ago

Looks like encoder acceleration is not working on my system running 240424. enc() always returns delta of -1 or 1.

I think this is related to https://github.com/monome/norns/pull/1776/commits/d4eb4b39db7fda6137f9fac3e24a2f3efc2bbe62

tehn commented 4 months ago

is this inside of a script?

if so, you need to explicitly enable it: https://monome.org/docs/norns/reference/encoders

norns.enc.accel(n,enable)

tehn commented 4 months ago

apologies, to clarify, both pots and encoders "have" acceleration but their implementation is different. i should rename the redirection functions inside norns.lua to make more sense

dstroud commented 4 months ago

What I mean is that the enc() Lua function now returns a delta value of exclusively -1 or 1 rather than a wider range of values proportional to how quickly the encoder is turned, irrespective of whether I call norns.enc.accel(0, true) or norns.enc.accel(0, false)

tehn commented 4 months ago

yes, found the typo.

if you'd like to git pull in the minor lua fix ahead of an update, that should do it for you