search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
614 stars 144 forks source link

should clearing the script always stop the engine? #1782

Open catfact opened 1 month ago

catfact commented 1 month ago

suggest addresing this user-surprising discrepancy in behaviors:

(https://llllllll.co/t/norns-studies/14109/231)

[quote] Is there a specific reason why maiden “stop” behaves like this? I would expect the “stop” button to be identical to K1 + K3. [/quote]

there is no specific reason. the K1+K3 behavior was hacked in at some point, directly to the menu input code:

https://github.com/monome/norns/blob/main/lua/core/menu/home.lua#L25-L26

this is clearly not architecturally sound. maiden calls norns.script.clear(), which is in like the "public API." the "private API" call _norns.free_engine() should just be added to norns.script.clear() if the desired behavior is for clearing the script to always stop the running audio engine. otherwise it won't be freed until a new engine is requested.

catfact commented 1 month ago

... i haven't checked: maybe there are times that we do in fact want to run the script cleanup without affecting supercollider. but it seems unlikely, right?

tehn commented 1 month ago

i am pretty certain script clear infers that we want to cleanup supercollider as well.

i can PR a fix.

On Mon, May 27, 2024 at 6:08 PM ezra buchla @.***> wrote:

... i haven't checked: maybe there are times that we do in fact want to run the script cleanup without affecting supercollider. but it seems unlikely, right?

— Reply to this email directly, view it on GitHub https://github.com/monome/norns/issues/1782#issuecomment-2134092672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4I4DAJBZMBL5IA6X42YLZEOVFJAVCNFSM6AAAAABILZMMJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGA4TENRXGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>