monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
630 stars 147 forks source link

allow tape looping behavior to be changed #1789

Open catfact opened 3 months ago

catfact commented 3 months ago

this behavior is actually controlled by a runtime flag called loopFile within the Tape module, but it does not have public setters. i believe adding setter and corresponding OSC handler would be sufficient to toggle looping.

https://github.com/monome/norns/blob/main/crone/src/Tape.h#L346

might be good to expose this to OSC / lua.

tehn commented 3 months ago

this would be good.

it doesn't seem like there's a good place in the PARAMETER menu that makes sense to control this (short of adding a new SUB for tape, which this would be the only option).

alternatively, i propose a minor rework of the TAPE UI:

if this seems like a good idea, i can work on this next week

dndrks commented 3 months ago

combing through old tickets surfaced: https://github.com/monome/norns/issues/766 @tehn , re: K2 -- could 'canceling' an in-progress PLAY inherit the current STOP functionality, leaving K3 free for PAUSE?

tehn commented 3 months ago

the UI opportunity is clear, but the tape module presently doesn't have a PAUSE state so that's an additional feature