provide more info on script errors

[pq]

From @pq on May 22, 2018 22:36

currently (at least some) script errors provide very little information to the REPL (e.g., ### SCRIPT ERROR and nothing more). if we're trapping the error it'd be great to pass more back (in the repl or log).

a few observations:

• load failures do produce output
• "null pointers" don't

to reproduce, put this into an init() and play:

local a = nil
print(a.tostring())

result:

# script run
# script init
### SCRIPT ERROR:

Copied from original issue: ngwese/maiden#82

[pq]

/cc @catfact

[pq]

From @catfact on May 22, 2018 22:38

norns.scripterror() is called with no arguments here: https://github.com/catfact/norns/blob/dev/lua/script.lua#L41

this should probably use norns.try (as far as i can tell)

this functionality seems messy and error-prone to me - interdependency on script.lua, menu.lua and norns.lua

[pq]

From @ngwese on May 22, 2018 22:39

i think this would be better filed against matron in the norns repo - maiden has no control over this as the repl is just echos whatever is sent over the socket

[pq]

@catfact should this get moved to the norns repo?

[pq]

From @catfact on May 22, 2018 22:39

yes i agree

[pq]

From @catfact on May 22, 2018 22:39

this stuff is also printed to the norns screen... sometimes? maybe?

[antonhornquist]

agreed this is important. must have been a quite recent change causing lua errors not to be reported in detail - there used to be stack traces.