search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
614 stars 144 forks source link

auto-stop tape player #374

Closed artfwo closed 5 years ago

artfwo commented 6 years ago

playing back tape recordings doesn't seem to stop after the file has finished playing, i.e. the player just continues to play silence, while displaying the same file and incrementing time.

antonhornquist commented 6 years ago

not sure this is related but i've experienced issues where tape continues to play even though it's indicated as stopped in the UI.

tehn commented 6 years ago

yes the tape doesn't have the polls implemented. needs them.

catfact commented 5 years ago

@tehn @antonhornquist is this done now?

tehn commented 5 years ago

this is not done i think. i believe the tape now loops (not sure if that is desired behavior) but the playback time counter is still just a lua-based metro whereas i should be using the crone poll instead.

the issue i guess was really about the playback counter.

antonhornquist commented 5 years ago

Lua side should display playback position based on the tape poll. IIRC there’s no looping going on. As @tehn says this is probably about the playback counter.

tehn commented 5 years ago

fixed by https://github.com/monome/norns/pull/651