monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
629 stars 145 forks source link

default input gain (hardware) #418

Closed catfact closed 6 years ago

catfact commented 6 years ago

while debugging some stuff, i realized that the input gains on my hardware are really different for each channel. i don't know if this is normal.

i also noticed:

tehn commented 6 years ago

you have a prototype right now-- the i2c-controlled gain stage was removed on the production units.

the solution for prototypes is to have the levels set to unity at startup by the init scripts. i thought @simonvanderveldt and i fixed this a couple months ago, but perhaps recent images lost the i2c setup (given it's used by just a couple units out there now)

simonvanderveldt commented 6 years ago

@tehn The commands are still there, just prefixed with a - so they won't fail the unit https://github.com/monome/norns-image/blob/master/config/norns-init.service#L11

@catfact Did the norns-init unit run correctly for you?

catfact commented 6 years ago

ah -sorry - i don't know. i'll check.

so @tehn can we remove the lua bindings for these hardware commands that aren't in the hardware anymore? can just set stuff from shell for protos right?

tehn commented 6 years ago

yes we can, and should. i apologize for not pulling them out sooner.

simonvanderveldt commented 6 years ago

@catfact Sorry, I missed the input part of the issue title, the link I posted goes to the commands for output.

The commands for the gain of the inputs are still in the unit but commented out https://github.com/monome/norns-image/blob/master/config/norns-init.service#L15 @tehn just to be sure: the gain staging was removed from both inputs and outputs?

tehn commented 6 years ago

correct. no i2c gain on input or output anymore for production units.