search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
630 stars 145 forks source link

scripts in subfolders under script/[author] lock menu cursor to menu > parameters #486

Closed antonhornquist closed 5 years ago

antonhornquist commented 6 years ago

I'm aware of discussions on changing script folder structure, but i guess this may be good to know anyhow. Cursor gets locked in menu > parameters when script is not contained directly under author folder.

To recreate:

  1. create a script utilizing params and add it to a folder under script/[author], such as script/jah/r
  2. load (select) the script
  3. go to MENU > PARAMETERS.
  4. press key2 to go back to MENU

Expected behavior: cursor should navigate back to main menu page. Actual behavior: cursor remains in MENU > PARAMETERS.

I believe this is due to some bug in menu logic. An error is thrown here: https://github.com/monome/norns/blob/master/lua/menu.lua#L1020

Stacktrace in screenshot.

image

catfact commented 5 years ago

@tehn @antonhornquist is this still happening?

tehn commented 5 years ago

will not fix as i'll be shortly rewriting this entire system