search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
630 stars 145 forks source link

engine unload on cleanup #604

Closed tehn closed 5 years ago

tehn commented 5 years ago

engine should get explicitly unloaded on cleanup (script unload)

catfact commented 5 years ago

there's an OSC path for explictly freeing the engine https://github.com/monome/norns/blob/master/sc/core/Crone.sc#L362 but it's missing weaver/lua glue

tehn commented 5 years ago

added glue: https://github.com/monome/norns/tree/free_engine

but it doesn't seem to actually unload the engine? tested with awake which uses PolyPerc by typing free_engine() into the REPL and confirming that sc received the command

catfact commented 5 years ago

ahh my bad

catfact commented 5 years ago

fixed by PRs #613, #614