search

monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
629 stars 145 forks source link

improve lua stack traces (pcall output) #780

Closed tehn closed 4 years ago

tehn commented 5 years ago

perhaps we can produce better error messages?

catfact commented 5 years ago

is this about lua stack traces (output of pcall?)

like, for example, getting name of table indexed by nil?

if so, i'd like to make the title more descriptive, add tags, that stuff

pq commented 5 years ago

is this about lua stack traces (output of pcall?)

👍

like, for example, getting name of table indexed by nil?

i believe this is exactly right.

catfact commented 5 years ago

this will probably involve some magic in the lua eval module itself

perhaps around this salty FIXME https://github.com/monome/norns/blob/dev/matron/src/lua_eval.c#L150

tehn commented 4 years ago

revisiting this, it was very dumb of me not to actually include an example of a bad error trace. so i'm not sure what this was originally trying to address. @pq any context you could add?

tehn commented 4 years ago

closing this as i don't have a good reference case.