monome / norns

norns is many sound instruments.
http://monome.org
GNU General Public License v3.0
616 stars 144 forks source link

softcut phase offset #816

Closed tehn closed 5 years ago

tehn commented 5 years ago

one feature from the old softcut didn't make it forward: phase_offset

the phase_quant is always relative to 0 (this makes sense), but i'm looking to do weird things (in mlr specifically) where i want to check phase quantum with an offset.

ie, if phase quantum is 0.4s but the loop i'm interested in looking at starts at 1.0s, things don't line up as the start point is not a multiple of the quantum.

my hack for the old softcut was to add the offset command. will re-attempt to dip into crone a bit later.

catfact commented 5 years ago

so, IIUC, you would add an offset before quantizing, like here? https://github.com/monome/norns/blob/master/crone/src/softcut/SoftCutVoice.cpp#L187

tehn commented 5 years ago

yep that'd do it i think

thanks for the line #

tehn commented 5 years ago

fixed by #819