search

monome / serialosc

multi-device, bonjour-capable monome OSC server
http://monome.org/docs/serialosc/osc
Other
146 stars 32 forks source link

Allow using system installed libuv #32

Closed simonvanderveldt closed 6 years ago

simonvanderveldt commented 6 years ago

Instead of the included git submodule. Can be enabled using the configure flag --enable-system-libuv

This fixes #30

@wrl I went for an explicit configure option instead of "magic" based on if the submodule would or wouldn't exist. IMHO this is a bit cleaner plus it allows the build to fail when the packager wants to use the system libuv and it isn't installed (and the git submodule is checked out).

Also, I didn't make the flag Linux specific since libuv can be installed systemwide on both macOS (http://formulae.brew.sh/formula/libuv) and Windows (https://www.nuget.org/packages/Libuv/).

wrl commented 6 years ago

👌 looks good, dude

thanks :)

wrl commented 6 years ago

merged (with rewritten commit msg) as b1e9a64739fe935355af30444a2ee739e0ab3e58