search

monome / softcut-studies

17 stars 8 forks source link

$HOME path is hardcoded in most of the scripts #1

Closed simonvanderveldt closed 4 years ago

simonvanderveldt commented 4 years ago

For example https://github.com/monome/softcut-studies/blob/master/5-filters.lua#L9

@tehn What would be the correct way of fixing this? I'd normally say include, but that only works for Lua files

tehn commented 4 years ago

i need to use the _path.dust var which is set in config.lua

but that also gets back to $HOME

how to do you propose tracking the dust location across buildroot/raspbian?

simonvanderveldt commented 4 years ago

Using the $HOME env car is fine, only hard coded paths are a problem.

tehn commented 4 years ago

fixed

simonvanderveldt commented 4 years ago

@tehn How can we fix this one? https://github.com/monome/softcut-studies/blob/f559bd694ff1660f2a34fb0283d83a3732e89e2c/3-cut.lua#L6

tehn commented 4 years ago

fixed, sorry to have missed it

simonvanderveldt commented 4 years ago

No problem at all :) Thanks for the quick fix!