search

monome / teletype

monome eurorack module
GNU General Public License v2.0
195 stars 82 forks source link

tele_var_t: void (*func)(uint8_t); #21

Closed samdoshi closed 7 years ago

samdoshi commented 8 years ago

In tele_var_t the function pointer func is defined as:

void (*func)(uint8_t);

What's the uint8_t argument for? The only place func is called is here. None of the v_* functions make use of the n argument.

Shall I get rid of it and submit a PR?

tehn commented 8 years ago

certainly!

On Sat, Apr 2, 2016 at 9:12 AM, Sam Doshi notifications@github.com wrote:

In tele_var_t the function pointer func is defined as:

void (*func)(uint8_t);

What's the uint8t argument for? The only place func is called is here https://github.com/monome/teletype/blob/master/src/teletype.c#L1563. None of the v* functions make use of the n argument.

Shall I get rid of it and submit a PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/monome/teletype/issues/21