monome / teletype

monome eurorack module
GNU General Public License v2.0
203 stars 84 forks source link

new OP `HZ`, converts v/oct to hz/v #246

Closed a773music closed 3 years ago

a773music commented 3 years ago

What does this PR do?

Add a new OP HZ for converting v/oct to hz/v

Provide links to any related discussion on lines.

https://llllllll.co/t/teletype-3-2-feature-requests-and-discussions/32052/369

How should this be manually tested?

HZ V -2 = VV 25 HZ V -1 = VV 50 HZ V 0 = V 1 HZ V 1 = V 2 HZ V 2 = V 4 HZ V 3 = V 8

Any background context you want to provide?

Allows pitch control from the teletype to synths with hz/v tracking like the Korg MS-20

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

a773music commented 3 years ago

Any thoughts on this? Things I should do differently or improve?

tehn commented 3 years ago

looks good to me! @scanner-darkly feel free to merge after you get a quick glance