monome / teletype

monome eurorack module
GNU General Public License v2.0
203 stars 84 forks source link

Add `EV` alias for `EVERY` op #263

Closed eimhin closed 3 years ago

eimhin commented 3 years ago

What does this PR do?

Adds an EV alias for the EVERY op to save character space.

Provide links to any related discussion on lines.

Comment on Lines: https://llllllll.co/t/teletype-3-2-feature-requests-and-discussions/32052/443

How should this be manually tested?

Use EV instead of EVERY in a script.

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

scanner-darkly commented 3 years ago

EV to me seems more intuitive - i would say this is the case where some community discussion would be helpful, could you make a post about your proposed change here? https://llllllll.co/t/teletype-3-2-feature-requests-and-discussions/32052

eimhin commented 3 years ago

EV to me seems more intuitive - i would say this is the case where some community discussion would be helpful, could you make a post about your proposed change here? https://llllllll.co/t/teletype-3-2-feature-requests-and-discussions/32052

Sorry! I forgot to add the discussion link. I added it to the description now. I didn’t get too much feedback - just likes. I agree EV is probably better.

scanner-darkly commented 3 years ago

@eimhin - sorry, there was another PR before yours i just merged, which caused conflicts with yours, could you do another commit to resolve the conflicts? i can help if you're not sure how to do it.

eimhin commented 3 years ago

@scanner-darkly Sure, I can take care of it tonight or tomorrow morning, if that’s ok.

scanner-darkly commented 3 years ago

sounds good!

eimhin commented 3 years ago

@scanner-darkly Ok, the conflicts are fixed! Thanks