monome / teletype

monome eurorack module
GNU General Public License v2.0
204 stars 84 forks source link

live mode dashboard / clean up #264

Closed scanner-darkly closed 3 years ago

scanner-darkly commented 3 years ago

What does this PR do?

How should this be manually tested?

see the doc for the LIVE.DASH op

I have,

scanner-darkly commented 3 years ago

the tests were definitely passing locally, not sure why travis is complaining, will take a look

scanner-darkly commented 3 years ago

the tests are failing on ops added in #PR257. @attejensen can you take a look?

scanner-darkly commented 3 years ago

so looks like clang format broke some of the ops - which is why the tests passed for me locally - i ran clang format after. should be fixed now.

desolationjones commented 3 years ago

so looks like clang format broke some of the ops - which is why the tests passed for me locally - i ran clang format after. should be fixed now.

Won't these break every time they are formatted? Perhaps we should wrap that section in a // clang-format off.

scanner-darkly commented 3 years ago

@desolationjones math.c already has clang-format off but it still modified it. not sure why..