search

monome / teletype

monome eurorack module
GNU General Public License v2.0
197 stars 83 forks source link

Disallow SCENE in I scripts #35

Closed samdoshi closed 6 years ago

samdoshi commented 8 years ago

This is a hypothetical failure, I haven't actually tested it.

It would be possible to create an infinite loop of SCENE loads, if those loads are trigger by the I script on scene load (or any script that it calls).

We should prevent SCENE running when the I script is triggered on load, but not when I is running via SCRIPT and a manual trigger.

I think the way I'd implement this is to modify the execution state / context to include a member is_scene_initialising and use that to prevent any actions we don't want run.

tehn commented 8 years ago

good thinking. i certainly had not considered this.

On Tue, Apr 12, 2016 at 4:41 AM, Sam Doshi notifications@github.com wrote:

This is a hypothetical failure, I haven't actually tested it.

It would be possible to create an infinite loop of SCENE loads, if those loads are trigger by the I script on scene load (or any script that it calls).

We should prevent SCENE running when the I script is triggered on load, but not when I is running via SCRIPT and a manual trigger.

I think the way I'd implement this is to modify the execution state / context to include a member is_scene_initialising and use that to prevent any actions we don't want run.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/monome/teletype/issues/35